Align exception message with exception handling condition #4377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "A job instance already exists and is complete for parameters=" + jobParameters | ||
| + ". If you want to run this job again, change the parameters."); | ||
| "A job instance already exists and is complete for identifying parameters=" | ||
| + identifyingJobParameters + ". If you want to run this job again, " |
Contributor
There was a problem hiding this comment.
This will slightly modify the exception's message as it now uses Collection#toString rather than JobParameters#toString. I will update this on merge by wrapping the identifying job parameters in a JobParameters instance.
Contributor
|
Rebased and merged as 11169ba. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4025
Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:
mainbranch and squash your commitsFor more details, please check the contributor guide.
Thank you upfront!